Supports more locations for completions contextual types #21946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
force-pushed
the
completionsRecommended_contextualTypes
branch
from
9c561d2 to
9eb7461
Compare
ghost
force-pushed
the
completionsRecommended_contextualTypes
branch
from
9eb7461 to
6f757a4
Compare
mhegazy
approved these changes
Feb 17, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports more cases where we didn't get a contextual type before. As in #20020, adding this functionality to
completions.tsinstead of the checker, because e.g. the contextual type at a(will only matter in completions.